BUG: Fix tz-aware comparison in plot() causing failures when timeseries begins at DST boundary #63013
+23
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
reviewed
Nov 7, 2025
| if index.tz is not None: | ||
| # Compare naive local times directly | ||
| period_naive = period.to_timestamp() | ||
| index_naive = index[0].tz_localize(None) # Strips tz, keeps local time |
Member
There was a problem hiding this comment.
can you call this ts_naive instead of index_naive.
jbrockmendel
reviewed
Nov 7, 2025
| index_naive = index[0].tz_localize(None) # Strips tz, keeps local time | ||
| return period_naive == index_naive | ||
| else: | ||
| return period.to_timestamp() == index[0] |
Member
There was a problem hiding this comment.
an you call period.to_timestamp() just once before the branch
Member
|
needs a test for the bug this addresses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.